Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat(db): add more indexes for inactive accounts query #17967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chenba
Copy link
Contributor

@chenba chenba commented Nov 4, 2024

Because:

  • we need more indexes to cover the intensive inactive accounts query

This commit:

  • add indexes to three tables join'd in the query

@chenba chenba requested a review from a team as a code owner November 4, 2024 15:31
@chenba
Copy link
Contributor Author

chenba commented Nov 4, 2024

I need to work with SRE to try the migration first. It's ready for review, but please do not merge it.

@chenba
Copy link
Contributor Author

chenba commented Nov 4, 2024

I just realized that I didn't update target-patch.json. I will do so soon.

@chenba
Copy link
Contributor Author

chenba commented Nov 4, 2024

I've added a sample query to the jira comments.

Because:
 - we need more indexes to cover the intensive inactive accounts query

This commit:
 - add indexes to three tables join'd in the query
@chenba chenba force-pushed the fxa-10686-indexes branch from e7fa63d to 1f4883f Compare November 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants