deps(sentry): upgrade Sentry to version 8 #17697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#17505 but without Dan's updates for test timeouts. |
dschom
approved these changes
Sep 25, 2024
chenba
force-pushed
the
sentry-8-no-timeout-updates
branch
from
83dc649 to
d3be5f3
Compare
Becuase: - After upgrading sentry we were seeing test timeouts - There were some kinda weird patterns in place for these tests anyways - Test server wasn't getting cleaned up - Test server start up is taking longer (presumably because of sentry upgrade?) This Commit: - Moves before an after blocks next to each other so setup and tear down are easy to follow - Makes sure test server start / stop is done in before each blocks - Increase test timeouts to 60s when test server is used - Switches to async/await for before and after blocks, which feels less error prone
Because: - Sentry 8 is the latest version This commit: - deletes some integration code since Sentry does it automatically - updates code to use the Sentry 8 API - updates a few proxyquire calls because they were cause module not found errors in CI
chenba
force-pushed
the
sentry-8-no-timeout-updates
branch
from
d3be5f3 to
81c4761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: