This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(scripts): ignore bouncing accounts in verification reminders #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak for the verification reminders script, if the mailer fails with a bounce error then just delete the reminder records and ignore that account.
It turns out it's quite hard to force a bounce error in local testing. I tried with a non-existent domain and a non-existent account at a valid domain, but the email service succeeded with both. So I'm going to mark this as
WIPand try again tomorrow. We can still cut the train in the meantime, I'll make a point release if I get it to fail.