This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Added partial support for meta.com #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekmadan30
suggested changes
Mar 22, 2024
|
I would love to have support for the Meta home page, but adding support for the more modern banner seems to be much more difficult than for the one for which I propose to add support in this PR. Maybe with some help I could figure it out though ¯\_(ツ)_/¯ |
|
Superseded by #505. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I modified the existing rule for the standard cookie banner used by Meta on a large part of their websites to add partial support for meta.com. In practice, only about.meta.com seems to be the beneficiary of this change, but it is still better than no support at all, isn't it?
Resolves #476