Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More arbitrary c8 ignores #4305

Merged
merged 2 commits into from
Mar 6, 2024
Merged

More arbitrary c8 ignores #4305

merged 2 commits into from
Mar 6, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Mar 6, 2024

As we add code, more existing code suddenly gets marked as uncovered by unit tests intermittently. This adds c8 ignore comments for everything that turned up when running

npm test -- --no-cache --runInBand

But I really hope this gets fixed upstream soon, because this isn't sustainable.

For more context, see:
#4234

And the (hopefully correct) upstream issue:
istanbuljs/v8-to-istanbul#236

Ugh. I feel dirty.

As we add code, more existing code suddenly gets marked as
uncovered by unit tests intermittently. This adds c8 ignore
comments for everything that turned up when running

   npm test -- --no-cache --runInBand

But I really hope this gets fixed upstream soon, because this isn't
sustainable.

For more context, see:
#4234

And the (hopefully correct) upstream issue:
istanbuljs/v8-to-istanbul#236
@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Mar 6, 2024
@Vinnl Vinnl requested review from codemist and flozia March 6, 2024 11:07
@Vinnl Vinnl self-assigned this Mar 6, 2024
Copy link
Collaborator

@flozia flozia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions! It is very unfortunate that there seems to be no obvious pattern as to why there are more and more uncovered lines appearing.

@flozia flozia merged commit 07805c7 into main Mar 6, 2024
15 checks passed
@flozia flozia deleted the c8-ignores branch March 6, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants