AMP FTS metrics #6560
Merged
AMP FTS metrics #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c0w3
approved these changes
Jan 16, 2025
| for term in fts_content.split_whitespace() { | ||
| *actual_counts.entry(term).or_default() += 1; | ||
| } | ||
| assert_eq!(actual_counts, expected_counts); |
There was a problem hiding this comment.
Why not simply assert_eq!(fts_content, expected)? That would simplify this test logic, making bugs less likely, and I think it's OK to make an assumption about the order of words in fts_content.
There was a problem hiding this comment.
This was my first try, but the HashSet messes it all up because the order changes each test.
There was a problem hiding this comment.
I see, I didn't realize that.
bendk
force-pushed
the
push-unrssxklpums
branch
2 times, most recently
from
1b4f7b4 to
502af68
Compare
These seem like they could be useful for the experiment. I'm not sure we'll be able to hook them up but we might as well try. Refactored the logic to get the full keywords and added tests for it since we're now using it in two places.
bendk
force-pushed
the
push-unrssxklpums
branch
from
502af68 to
fff3e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem like they could be useful for the experiment. I'm not sure we'll be able to hook them up but we might as well try.
Refactored the logic to get the full keywords and added tests for it since we're now using it in two places.
PR note: This one's on top of the other since I think that one's pretty close to landing and this one I'm less sure of. The second commit has changes specific to this one.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.