Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support keydb feature #6542

Closed
wants to merge 1 commit into from
Closed

WIP: support keydb feature #6542

wants to merge 1 commit into from

Conversation

jo
Copy link
Contributor

@jo jo commented Jan 3, 2025

This adds a feature keydb to rc_crypto's nss create, which enables the ensure_initialized_with_profile_dir initialize function. This configures NSS to use a profile and persist keys into key4.db.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jo jo changed the title support keydb feature WIP: support keydb feature Jan 3, 2025
@jo jo force-pushed the nss-persistence branch from 3ab93b5 to e32b282 Compare January 3, 2025 08:49
This adds a feature `keydb` to rc_crypto's nss create, which enables the
`ensure_initialized_with_profile_dir` initialize function. This
configures NSS to use a profile and persist keys into key4.db.
@jo jo force-pushed the nss-persistence branch from e32b282 to f7129ec Compare January 3, 2025 10:11
@jo jo closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant