Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo workspace dependencies. #6513

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mhammond
Copy link
Member

@mhammond mhammond commented Dec 4, 2024

Once in m-c, many of our crates need to be excluded from the main workspace, which means they can't use workspace deps. So we don't bother using them anywhere.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@mhammond mhammond requested a review from bendk December 4, 2024 02:26
@mhammond mhammond force-pushed the push-pwyzntrkslks branch 2 times, most recently from d14fbcf to fc53ec0 Compare December 4, 2024 14:49
Once in m-c, many of our crates need to be excluded from the main workspace,
which means they can't use workspace deps. So we don't bother using them anywhere.
@mhammond mhammond enabled auto-merge December 4, 2024 15:02
@mhammond mhammond added this pull request to the merge queue Dec 4, 2024
Merged via the queue into mozilla:main with commit 372bee8 Dec 4, 2024
15 of 16 checks passed
@mhammond mhammond deleted the push-pwyzntrkslks branch December 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants