Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1400258 - write cot logs to live_backing.log #317

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bug 1400258 - write cot logs to live_backing.log #317

wants to merge 2 commits into from

Conversation

escapewindow
Copy link
Contributor

No description provided.

@escapewindow
Copy link
Contributor Author

Essentially #232 again. Github made me open a new PR since I force-pushed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 391c1ef on escapewindow:cot-log into 4e9b581 on mozilla-releng:master.

@coveralls
Copy link

coveralls commented Mar 17, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9ee4faf on escapewindow:cot-log into bc321cc on mozilla-releng:master.

@escapewindow
Copy link
Contributor Author

@tomprince do you still have objections to this?
We seem to follow this pattern in other worker implementations, e.g. the docker-worker task live_backing.log also containing vcs log information before the task command runs.

@tomprince
Copy link
Contributor

I'm still sad that this seems to be the best solution, but given that treeherder doesn't have support for multiple logs, this is probably the correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@escapewindow @coveralls @tomprince