Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scriptworker hangs if script writes really long line #362

Open
tomprince opened this issue Jul 5, 2019 · 1 comment
Open

Scriptworker hangs if script writes really long line #362

tomprince opened this issue Jul 5, 2019 · 1 comment

Comments

@tomprince
Copy link
Contributor

If a balrogworker submit-toplevel task is re-run after all the balrog submit jobs, then the blob printed out by balrogclient here is on the order of 600k. This cause the log processing on scriptworker to hang (or something). Balrogscript currently writes logs synchronously, which meant it hung trying to write the log.

@escapewindow
Copy link
Contributor

escapewindow commented Mar 9, 2020

Hm. Should we document this, wrap, truncate, throw an exception, or other? I think the middle 3 solutions require us to check the length of each log line.

Finding out what is hanging and fixing it might be the best solution. We may want to add a test case to make sure we don't regress in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants