Allow longer lines before eliding #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomprince should probably look at this too. |
srfraser
approved these changes
Feb 19, 2020
tomprince
approved these changes
Feb 19, 2020
| @@ -16,8 +16,8 @@ | |||
|
|
|||
| def _json_log_data(data): | |||
| log = json.dumps(data) | |||
| if len(log) > 100: | |||
There was a problem hiding this comment.
I guess maybe this should be a constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current eliding that happens as part of Balrog submission ends up not showing any useful parts of the request, which makes debugging submission issues next to impossible.
This patch should elide long enough to show the entire body of regular requests, while still eliding enough to avoid mozilla-releng/scriptworker#362.