Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MTE-3854 Menu Refactor for XCUITests (WIP) #23160

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

clarmso
Copy link
Collaborator

@clarmso clarmso commented Nov 15, 2024

📜 Tickets

Jira ticket

💡 Description

Work in progress: Update BrowserTabMenu for the upcoming menu refactor work. 💪🏼

Todo:

  • Transplant all actions and transitions from the old BrowserTabMenu to the new menu.

Smoke Tests progress:
✅ Smoketest1 (no new test failures)
❌ Smoketest2
❓ Smoketest3
❓ Smoketest4

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@clarmso clarmso requested review from a team as code owners November 15, 2024 17:37
@clarmso clarmso added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 15, 2024
@clarmso clarmso changed the title Refactor MTE-3854 Menu Refactor for XCUITests Refactor MTE-3854 Menu Refactor for XCUITests (WIP) Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge ⛔️ This issue is a work in progress and is not ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant