Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10520 ⁃ [Menu][Accessibility] VoiceOver focus moves outside of the action sheet when the action sheet is open (backport #23154) #23159

Open
wants to merge 1 commit into
base: release/v133
Choose a base branch
from
Open

Bugfix FXIOS-10520 ⁃ [Menu][Accessibility] VoiceOver focus moves outside of the action sheet when the action sheet is open (backport #23154) #23159

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 15, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Changed the modalPresentationStyle for iPhone, without affecting the UX or UI.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #23154 done by [Mergify](https://mergify.com).

@dicarobinho @mergify
Bugfix FXIOS-10520 ⁃ [Menu][Accessibility] VoiceOver focus moves outs…
65fd8f6 
…ide of the action sheet when the action sheet is open (#23154)

FXIOS-10520 #23060 ⁃ [Menu design][Accessibility] VoiceOver focus moves outside of the action sheet when the action sheet is open

(cherry picked from commit 821c63e)
@mergify mergify bot requested a review from a team as a code owner November 15, 2024 16:01
@mergify mergify bot requested review from ih-codes and removed request for a team November 15, 2024 16:01
@mergify mergify bot mentioned this pull request Nov 15, 2024
Merged
6 tasks
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.58%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 30.59

File Coverage
BrowserCoordinator.swift 71.57% ✅

Generated by 🚫 Danger Swift against 65fd8f6

@ih-codes ih-codes added the weekly-release Tagging backports for rapid release label Nov 15, 2024
@adudenamedruby
Copy link
Contributor

adudenamedruby commented Nov 15, 2024 •
edited
Loading

@dicarobinho is this for 133 or 133.1? If 133, then, please remove the weekly-releaselabel so RelMan knows to merge for the RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adudenamedruby adudenamedruby adudenamedruby approved these changes

@ih-codes ih-codes Awaiting requested review from ih-codes ih-codes is a code owner automatically assigned from mozilla-mobile/fxios-eng

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mobiletest-ci-bot @adudenamedruby @ih-codes @dicarobinho