Refactor FXIOS-10467 - Remove force_cast violations from Sistem services & Logging #23150
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import UIKit | ||
| import Shared | ||
|
|
||
| class MenuBuilderHelper { | ||
| private let logger: Logger | ||
|
|
||
| init(logger: Logger = DefaultLogger.shared) { |
There was a problem hiding this comment.
That looks good, i'd only move the init after the structs, so the init is with the other methods
| @@ -255,7 +280,13 @@ class MenuBuilderHelper { | |||
|
|
|||
| if #available(iOS 15, *) { | |||
There was a problem hiding this comment.
We can also remove the #if available now we support from iOS 15
| ($0 as! UIKeyCommand).wantsPriorityOverSystemBehavior = true | ||
| guard let fileMenuKeyCommand = $0 as? UIKeyCommand else { | ||
| logger.log("Failed to cast file menu child to UIKeyCommand in MenuBuilderHelper class", | ||
| level: .fatal, |
There was a problem hiding this comment.
i'd log those as a .info level since there is no crash there and we don't send them to sentry as well.
Same for the other logs. i'd also use .lifecycle i see there isn't a proper one for menu but i guess lifecycle is more general
| self.alterEventForCustomCrash(event: event, crash: crashReport) | ||
| } else { | ||
| self.logger.log("Encountered an error that is not a CustomCrashReport: \(String(describing: event.error))", | ||
| level: .fatal, |
There was a problem hiding this comment.
Also here i'd go to .info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
force_castviolations from:📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)