Refactor FXIOS-10467 - Remove force_cast violations from Utilities and applications support #23149
+65
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 30.84
Generated by 🚫 Danger Swift against 6688ee4 |
mattreaganmozilla
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Thank you @bmihai23 for this PR 👍 Added a couple minor comments but overall changes lgtm.
| @@ -146,7 +146,9 @@ class UITestAppDelegate: AppDelegate, FeatureFlaggable { | |||
| let output = URL(fileURLWithPath: "\(dirForTestProfile)/places.db") | |||
|
|
|||
| let enumerator = FileManager.default.enumerator(atPath: dirForTestProfile) | |||
| let filePaths = enumerator?.allObjects as! [String] | |||
| guard let filePaths = enumerator?.allObjects as? [String] else { | |||
| fatalError("Failed to cast enumerator.allObjects to [String] during filePaths extraction") | |||
There was a problem hiding this comment.
@bmihai23 Can we please double-check if there is any other way to handle this besides fatalError? This will crash just like as!, so this change really doesn't provide much benefit.
Comment on lines
+60
to
+62
| self.logger.log("Failed to cast task to BGAppRefreshTask", | ||
| level: .fatal, | ||
| category: .lifecycle) |
There was a problem hiding this comment.
This PR adds several new .fatal logs; I think that's fine, since these would be crashes anyway. But @cyndichin @adudenamedruby please LMK if we have an official policy (or team plan) on how we're updating these force-cast violations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
force_castviolations from:📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)