Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-9671-[Native Error Page] images and bold text for generic error page #23143

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tusharC95
Copy link
Collaborator

@tusharC95 tusharC95 commented Nov 15, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Added:

  • securityError image.
  • Support for fetching generic error strings.
  • Bold text for URL in error description.
  • font style for error description.

For reference: Generic certificate screen with no error code

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

Screenshots

iPhone SE 3rd Gen

Portrait Landscape
Simulator Screenshot - iPhone SE (3rd generation) - 2024-11-15 at 11 45 10 Simulator Screenshot - iPhone SE (3rd generation) - 2024-11-15 at 11 45 26

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 15, 2024

Messages
📖 Project coverage: 32.11%
📖 Edited 8 files
📖 Created 4 files

Client.app: Coverage: 30.86

File Coverage
String+Extension.swift 55.26%
NativeErrorPageViewController.swift 83.89%
NativeErrorPageState.swift 92.86%
NativeErrorPageHelper.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 4a9c181

@tusharC95 tusharC95 marked this pull request as ready for review November 15, 2024 17:09
@tusharC95 tusharC95 requested a review from a team as a code owner November 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants