Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary Automated test changes for toolbar redesign #23086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preliminary Automated test changes for toolbar redesign #23086

wants to merge 1 commit into from

Conversation

dragosb01
Copy link
Collaborator

📜 Tickets

https://mozilla-hub.atlassian.net/browse/MTE-2808

💡 Description

PR created just to check the smoke tests with the toolbar redesign experiment on

@dragosb01 dragosb01 added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 13, 2024
@dragosb01 dragosb01 requested review from a team as code owners November 13, 2024 15:01
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 13, 2024 •
edited
Loading

Messages
📖 Edited 27 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 2cd930e

@isabelrios
Copy link
Contributor

@dragosb01 there are 4 tests failing in the smoketest:

  • testPrivateTab
  • testOpenNewTabLandscape
  • testStandardProtectionLevel
  • testPopUpBlocker

Are these known? due to issues to be fixed or automation that needs changes? Thanks!

@clarmso clarmso self-requested a review November 13, 2024 18:19
@dragosb01
Copy link
Collaborator Author

@dragosb01 there are 4 tests failing in the smoketest:

  • testPrivateTab
  • testOpenNewTabLandscape
  • testStandardProtectionLevel
  • testPopUpBlocker

Are these known? due to issues to be fixed or automation that needs changes? Thanks!

i will have a look, at some point i had 0 failures.

@isabelrios isabelrios changed the title Preliminary changes for toolbar redesign Preliminary Automated test changes for toolbar redesign Nov 14, 2024
@thatswinnie
Copy link
Contributor

@dragosb01 there are 4 tests failing in the smoketest:

  • testPrivateTab
  • testOpenNewTabLandscape
  • testStandardProtectionLevel
  • testPopUpBlocker

Are these known? due to issues to be fixed or automation that needs changes? Thanks!

i will have a look, at some point i had 0 failures.

Could this happen because the feature flag for "one tap new tab" is turned on as well? We could turn this off for now while the tests get fixed.

@dragosb01
Copy link
Collaborator Author

@dragosb01 there are 4 tests failing in the smoketest:

  • testPrivateTab
  • testOpenNewTabLandscape
  • testStandardProtectionLevel
  • testPopUpBlocker

Are these known? due to issues to be fixed or automation that needs changes? Thanks!

i will have a look, at some point i had 0 failures.

Could this happen because the feature flag for "one tap new tab" is turned on as well? We could turn this off for now while the tests get fixed.

It wasn't because of the flag, the tests required some changes

@dragosb01
Copy link
Collaborator Author

testOpenLinkFromPDF is failing because the link inside the pdf is not loading - website offline currently

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

This pull request has conflicts when rebasing. Could you fix it @dragosb01? 🙏

@isabelrios
Copy link
Contributor

@dragosb01 all tests are fixed now right? could you please confirm? thanks!

@dragosb01
Copy link
Collaborator Author

@dragosb01 all tests are fixed now right? could you please confirm? thanks!

yes, all the smoke tests are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelrios isabelrios Awaiting requested review from isabelrios isabelrios is a code owner automatically assigned from mozilla-mobile/fxios-automation-1

@clarmso clarmso Awaiting requested review from clarmso

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Do Not Merge ⛔️ This issue is a work in progress and is not ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dragosb01 @mobiletest-ci-bot @isabelrios @thatswinnie