Add FXIOS-10462 Enhanced Tracking Protection Connection Status Refresh #23052
Conversation
|
thanks @petruSt24! I believe this PR also has the navigation logic added as well, not sure if that was intentional or if it will be updated to only include refresh logic. et me know if this PR is still ready for review. If so, my comment from the previous PR applies here too. #22899 |
|
@cyndichin yes this will be updated to have the navigation based on the example you provided, but will do it in another PR as I'll still need the new actions from this one |
| if let navigateTo = state.navigateTo { | ||
| switch navigateTo { | ||
| case .home: | ||
| navigationController?.popToRootViewController(animated: true) | ||
| case .back: | ||
| navigationController?.popViewController(animated: true) | ||
| case .close: | ||
| enhancedTrackingProtectionMenuDelegate?.didFinish() | ||
| case .settings: | ||
| enhancedTrackingProtectionMenuDelegate?.settingsOpenPage(settings: .contentBlocker) | ||
| } |
There was a problem hiding this comment.
since this will be addressed in a separate PR, should we put a TODO instead here instead of implementing the navigation logic?
There was a problem hiding this comment.
I would add a TODO but removing the navigation code would render the navigation bar unresponsive until the other PR is merged, is that preferred?
📜 Tickets
Jira ticket
Github issue
💡 Description
Remade the previous PR after a bad rebase, added only the refresh action in this one but I have another PR that handles the back/dismiss navigation in the BrowserViewController
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)