Skip to content

Commit

Permalink
Fix wide dispatch for convert
Browse files Browse the repository at this point in the history
Caused issues on Julia 1.9 and below
  • Loading branch information
moyner committed Jan 28, 2024
1 parent 3de0cb3 commit 23f573d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MultiComponentFlash"
uuid = "35e5bd01-9722-4017-9deb-64a5d32478ff"
authors = ["Olav Møyner <[email protected]>"]
version = "1.1.9"
version = "1.1.10"

[deps]
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
Expand Down
2 changes: 1 addition & 1 deletion src/flow_coupler_types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function FlashedPhase(n::Integer, T::DataType = Float64)
return FlashedPhase(x, Z)
end

function Base.convert(::Type{FlashedPhase{T, Vector{T}}}, ph::FlashedPhase{K, Vector{K}}) where {T, K<:ForwardDiff.Dual}
function Base.convert(::Type{FlashedPhase{T, Vector{T}}}, ph::FlashedPhase{K, Vector{K}}) where {T<:AbstractFloat, K<:ForwardDiff.Dual}
F = x -> convert(T, value(x))
mf = map(F, ph.mole_fractions)
Z = F(ph.Z)
Expand Down

2 comments on commit 23f573d

@moyner
Copy link
Owner Author

@moyner moyner commented on 23f573d Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99718

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.1.10 -m "<description of version>" 23f573d5c895357ffe65e9b9cddd75fd177e1dbb
git push origin v1.1.10

Please sign in to comment.