Improve "not currently supported" part of README.md #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following Issue movio#136 , I just propose a quick README update to make it more explicit that unions can't be shared across services + a link to the FAQ to provide more details.
|
Good idea, thanks @pasdeloup. Just to be exhaustive, could you please add there's also no support for shared scalars and enums? There is discussion around this in #10. |
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 69.58% 69.61% +0.03%
==========================================
Files 24 24
Lines 2630 2630
==========================================
+ Hits 1830 1831 +1
+ Misses 669 668 -1
Partials 131 131
Continue to review full report at Codecov.
|
|
Thanks @pasdeloup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Issue #136 , I just propose a quick README update to make it more explicit that unions can't be shared across services + a link to the FAQ to provide more details.