[review] MIP-52: Aptos Gas Pool #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apenzk
changed the title
apenzk
requested changes
Nov 12, 2024
| @@ -0,0 +1,43 @@ | |||
| # MIP-52: Aptos Gas Pool | |||
| - **Description**: Introduces implementation specification for the Gas Pool in Aptos. | |||
There was a problem hiding this comment.
why "in Aptos" ? do you mean "in Aptos-core"?
|
|
||
| ## Motivation | ||
|
|
||
| The introduction of a Gas Pool in Aptos will allow for the recirculation of gas used in the Aptos ecosystem. This ensures the supply can remain fixed and the gas can be re-used for purposes such as rewarding. |
There was a problem hiding this comment.
do you mean "used in the Aptos-core system"?
also why ecosystem?
| The burn replacement approach replaces the `coin::burn_from` call in `transaction_fee::burn_fee` with a `coin::transfer_from` call to the Gas Pool. | ||
|
|
||
| ## Verification | ||
| **Outstanding**: |
There was a problem hiding this comment.
can this MIP be approved or should we await this outstanding points to be clarified @l-monninger ?
This was referenced Dec 16, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MIP-52