-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[review] MIP-48: Aptos Governance - Governed Gas Pool #48
base: main
Are you sure you want to change the base?
Conversation
New MIP to demonstrate how to re-route gas from |
We need a seperate Goverened Gas Pool FA Token for voting. |
Or Permissioned whitelisted accounts to vote only |
@0xmovses you have modified mip-0, it's showing as modification, not as a new file |
Will fix, danke. |
MIP/mip-0/README.md
Outdated
|
||
## Reference Implementation | ||
|
||
A reference implementation or a sample MIP following the MIP template can be provided to guide potential proposers. This MIP (MIP-0) serves as a practical example, aiding in understanding the format and expectations. | ||
The `governed_gas_pool.move` would interact with `aptos_framework.move`, seperating the roles of actual governance, voting and storing of gas and dispersing those funds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this potentially misses how aptos governance can be leveraged? You could gate the methods that are distributing the gas with @aptos_framework
which can be executed by creating a script that would be voted on via aptos governance and once majority can be executed by any key pair. This is how Aptos Governance works as a whole and decouples the two areas of concern you have highlighted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this sounds good. I needed to dig more into governance works on aptos. But this sounds like what we want!
This reverts commit 77bc60c.
done. |
Quick note Re. Governance: @l-monninger @Primata We will require it to be on L2 (aptos-governance) this is because it will send calls to :
BUT this creates a problem, for calling the Rate Limiter on L1, for obvious reasons, it can't communicate to the L1. For the case of Rate Limit call to the L1, we need some work around. Either
|
Summary
MIP-48