Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] MIP-48: Aptos Governance - Governed Gas Pool #48

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

0xmovses
Copy link
Contributor

@0xmovses 0xmovses commented Nov 6, 2024

Summary

MIP-48

@0xmovses 0xmovses changed the title feat: aptos-governance for Goverened Gas Pool [draft] MIP-48: Aptos Governance - Governed Gas Pool Nov 6, 2024
@0xmovses
Copy link
Contributor Author

0xmovses commented Nov 6, 2024

New MIP to demonstrate how to re-route gas from burn_internal to some owned address.

@0xmovses
Copy link
Contributor Author

0xmovses commented Nov 6, 2024

We need a seperate Goverened Gas Pool FA Token for voting.

@0xmovses
Copy link
Contributor Author

0xmovses commented Nov 6, 2024

Or Permissioned whitelisted accounts to vote only

@Primata
Copy link
Contributor

Primata commented Nov 6, 2024

@0xmovses you have modified mip-0, it's showing as modification, not as a new file

@0xmovses
Copy link
Contributor Author

0xmovses commented Nov 6, 2024

Will fix, danke.


## Reference Implementation

A reference implementation or a sample MIP following the MIP template can be provided to guide potential proposers. This MIP (MIP-0) serves as a practical example, aiding in understanding the format and expectations.
The `governed_gas_pool.move` would interact with `aptos_framework.move`, seperating the roles of actual governance, voting and storing of gas and dispersing those funds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this potentially misses how aptos governance can be leveraged? You could gate the methods that are distributing the gas with @aptos_framework which can be executed by creating a script that would be voted on via aptos governance and once majority can be executed by any key pair. This is how Aptos Governance works as a whole and decouples the two areas of concern you have highlighted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this sounds good. I needed to dig more into governance works on aptos. But this sounds like what we want!

@apenzk apenzk changed the title [draft] MIP-48: Aptos Governance - Governed Gas Pool [review] MIP-48: Aptos Governance - Governed Gas Pool Nov 12, 2024
@apenzk
Copy link
Contributor

apenzk commented Nov 12, 2024

@0xmovses you have modified mip-0, it's showing as modification, not as a new file

Will fix, danke.

done.

@0xmovses
Copy link
Contributor Author

0xmovses commented Dec 13, 2024

Quick note Re. Governance:

@l-monninger @Primata We will require it to be on L2 (aptos-governance) this is because it will send calls to :

  1. governed gas pool (move L2)
  2. insurance fund (move L2)
  3. Rate Limiter (move L2)

BUT this creates a problem, for calling the Rate Limiter on L1, for obvious reasons, it can't communicate to the L1. For the case of Rate Limit call to the L1, we need some work around. Either

  • Have a governance contract on L1 that we use for that call

    • problematic because of multiple sources of truth / two places for governance; though, not terrible
  • Relay a message from L2 governance to L1 via a trusted service

    • Less decentralised butI like this more, less of a lift, does what we need.

    cc @apenzk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants