Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] definition of glossary and MG #45

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[update] definition of glossary and MG #45

wants to merge 14 commits into from

Conversation

apenzk
Copy link
Contributor

@apenzk apenzk commented Nov 5, 2024 •
edited
Loading

Summary

This PR introduces changes to MIP-15, which defines MG and glossary

Reasoning

  • Addresses Issue 87
  • The MG standard is not used
  • A glossary is useful and is also what is commonly used in the space. E.g. https://ethereum.org/en/glossary/
  • The glossary should contain ALL terms including the ones on the branches. This implies having it on main only, is not sufficient. Hence the use of the wiki.

@apenzk apenzk changed the title [update] adding glossary term [update] adding glossary terms Nov 5, 2024
@apenzk apenzk mentioned this pull request Nov 5, 2024
Open
Primata
Primata previously requested changes Nov 6, 2024
View reviewed changes
GLOSSARY.md Outdated Show resolved Hide resolved
GLOSSARY.md Outdated Show resolved Hide resolved
@apenzk apenzk changed the title [update] adding glossary terms [update, draft] adding glossary terms Nov 11, 2024
@apenzk apenzk changed the title [update, draft] adding glossary terms [update MIP-15] definition of glossary and MG Jan 14, 2025
@apenzk apenzk added Urgent Needs urgent processing and removed check_for_outdated labels Jan 14, 2025
@apenzk apenzk changed the title [update MIP-15] definition of glossary and MG [update] definition of glossary and MG Jan 14, 2025
franck44
franck44 previously approved these changes Jan 15, 2025
View reviewed changes
@apenzk apenzk dismissed Primata’s stale review January 15, 2025 13:04

review has been addressed

@apenzk apenzk marked this pull request as ready for review January 15, 2025 13:16
@apenzk apenzk requested a review from l-monninger as a code owner January 15, 2025 13:16
@apenzk apenzk requested a review from vpallegar January 15, 2025 13:17
@apenzk apenzk requested a review from franck44 January 15, 2025 13:17
@apenzk apenzk requested review from vpallegar and Primata January 16, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmovses 0xmovses 0xmovses approved these changes

@l-monninger l-monninger Awaiting requested review from l-monninger l-monninger is a code owner

@franck44 franck44 Awaiting requested review from franck44

@vpallegar vpallegar Awaiting requested review from vpallegar

@Primata Primata Awaiting requested review from Primata

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Urgent Needs urgent processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apenzk @Primata @franck44 @0xmovses