Add more ActionKit methods #870
Conversation
crayolakat
commented
Aug 16, 2023
crayolakat
commented
- get_blackholed_email
- blackhole_email
- delete_user_data
parsons/action_kit/action_kit.py
Outdated
| @@ -233,6 +233,59 @@ def update_event(self, event_id, **kwargs): | |||
| ) | |||
| logger.info(f"{resp.status_code}: {event_id}") | |||
|
|
|||
| def get_blackholed_email(self, email): | |||
| """ | |||
| Get a blackholed email. | |||
There was a problem hiding this comment.
Because "blackholing" an email is a bit of an ActionKit-specific term, it might be helpful to either have a brief description of what a blackholed email is or a link to the ActionKit docs for blackholed emails.
Definition per ActionKit:
You may want to prevent certain email addresses or domains from receiving bulk and transactional messages from ActionKit.
Link: https://docs.actionkit.com/docs/manual/guide/mailings_tools.html#blackhole
parsons/action_kit/action_kit.py
Outdated
|
|
||
| def blackhole_email(self, email): | ||
| """ | ||
| Blackhole an email. |
There was a problem hiding this comment.
Could also use clarification on the definition of "blackhole".
There was a problem hiding this comment.
Agree with Josh that a little clarification in the docstrings for the "blackholed email" methods would be helpful, but it's not a blocker so I'll approve the PR. @crayolakat, feel free to merge as-is or update the docstrings and then merge.
