Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entity from campaign method #1140

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

ydamit
Copy link
Contributor

@ydamit ydamit commented Sep 18, 2024

Action Builder's API allows using the DELETE verb to remove entity records from campaigns. The test isn't a very meaningful one, but I guess something is better than nothing!

@ydamit ydamit added the connector update Work type - additions or changes to the functions of an existing Parsons connector label Sep 18, 2024
@ydamit ydamit self-assigned this Sep 18, 2024
@shaunagm
Copy link
Collaborator

Sorry about the gmail test failure @ydamit - it's suddenly happening to all our open PRs and we're struggling to figure out why.

@ydamit
Copy link
Contributor Author

ydamit commented Sep 19, 2024

Sorry about the gmail test failure @ydamit - it's suddenly happening to all our open PRs and we're struggling to figure out why.

No worries, @shaunagm ! I figured as much.

@bmos
Copy link
Contributor

bmos commented Oct 12, 2024

If someone reruns the checks on this after updating the branch from main, it should pass now.

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaunagm shaunagm merged commit 941c6a4 into main Oct 12, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector update Work type - additions or changes to the functions of an existing Parsons connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants