Airmeet Event Details connector with tests and documentation #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaunagm since this is a new class, similar to the OpenField connector, do you have any flags? Unlike my PR, looks like Ankur used the APIConnector which is good! |
codygordon
approved these changes
Jun 26, 2024
|
Overall this looks good. I am a little concerned about including completely untested code, especially given that this particular API seems to be inconsistent at times in what it returns. Is there any way to add test data so you can double-check? |
shaunagm
reviewed
Jun 27, 2024
shaunagm
requested changes
Jul 15, 2024
There was a problem hiding this comment.
I'm switching my status to "request changes" because it's my understanding that you're going to test out the last few endpoints in your production environment. Let me know once that's done and I'll approve + merge - or let me know if we need a different approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This connector adds support for Airmeet, a webinar platform.
Methods are included for everything listed in the Event Details API documentation. However, we don't currently have data in our account for booths, event tracks, or poll responses, so I haven't verified the data being returned from those.
This connector doesn't implement the Manage Registrations or Manage Events API methods.
Basic tests and documentation are included.