Don't warn about function argument type hint mismatches

This is getting too complicated when used together with phpstan's custom types, and phpstan can detect mismatches better anyway.
move-backend · Apr 12, 2024 · 306005e · 306005e
1 parent 701488d
commit 306005e
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/Lunr/Sniffs/Commenting/FunctionCommentSniff.php b/Lunr/Sniffs/Commenting/FunctionCommentSniff.php
@@ -417,14 +417,6 @@ protected function processParams(File $phpcsFile, $stackPtr, $commentStart)
                         }
 
                         $phpcsFile->addError($error, $stackPtr, $errorCode, $data);
-                    } else if ($typeHint !== $compareTypeHint && $typeHint !== '?'.$compareTypeHint) {
-                        $error = 'Expected type hint "%s"; found "%s" for %s';
-                        $data  = [
-                            $suggestedTypeHint,
-                            $typeHint,
-                            $param['var'],
-                        ];
-                        $phpcsFile->addError($error, $stackPtr, 'IncorrectTypeHint', $data);
                     }//end if
                 } else if ($suggestedTypeHint === '' && isset($realParams[$pos]) === true) {
                     $typeHint = $realParams[$pos]['type_hint'];