feat: fetch schema from schema-regsitry by schema string #308
+88
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroesch1
commented
Oct 9, 2024
rroesch1
commented
- enable users to lookup the schema id for a given schema string
|
Hey @rroesch1, Thanks for your contribution! Can you please add a JS script to the examples to test all these cases and add some Go tests? |
* enable users to lookup the schema id for a given schema string
rroesch1
force-pushed
the
schema-lookup
branch
from
8ffee37
to
3c65d03
Compare
|
rroesch1
commented
Oct 9, 2024
| "schemaType": srclient.Avro, | ||
| }, | ||
| ), | ||
| }, | ||
| }).Export().(*Schema) | ||
| assert.Equal(t, "test-subject", newSchema.Subject) | ||
| assert.Equal(t, 0, newSchema.Version) |
There was a problem hiding this comment.
fyi: the first version of a schema should have the version 1 (not 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.