Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simpify the configuration parsing #3

Merged
merged 2 commits into from
Jul 31, 2023
Merged

simpify the configuration parsing #3

merged 2 commits into from
Jul 31, 2023

Conversation

spacewander
Copy link
Member

No description provided.

@spacewander spacewander marked this pull request as ready for review July 19, 2023 06:18
doujiang24
doujiang24 reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm, just a small question, we need more memory for the config.Users, right?

@spacewander
Copy link
Member Author

ltgm, just a small question, we need more memory for the config.Users, right?

Yes. But when we add a new field, we don't need to add new code to parse it. We can set the original User to nil or use an intermediate config struct if the memory matters.

@doujiang24
Copy link
Member

use an intermediate config struct

yep, I think this could be better.

@spacewander
use intermediate conf
e5b1bff 
Signed-off-by: spacewander <[email protected]>
@doujiang24 doujiang24 merged commit 9629c8d into mosn:main Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spacewander @doujiang24