Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily test failures #3733

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix daily test failures #3733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/algorithms/test_algorithm_resumption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def test_algorithm_resumption(

copied_model = copy.deepcopy(model) # copy the model so the params will start from the same point

optimizer = torch.optim.SGD(model.parameters(), lr=0.1)
optimizer = torch.optim.Adam(model.parameters(), lr=0.01)
scheduler = torch.optim.lr_scheduler.StepLR(optimizer, step_size=1)

# Reduce training duration and data
Expand Down Expand Up @@ -82,7 +82,7 @@ def test_algorithm_resumption(
# create second trainer, load an intermediate checkpoint
# and continue training

optimizer = torch.optim.SGD(copied_model.parameters(), lr=0.1)
optimizer = torch.optim.Adam(copied_model.parameters(), lr=0.1)
scheduler = torch.optim.lr_scheduler.StepLR(optimizer, step_size=1)

alg = alg_cls(**alg_kwargs)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_full_nlp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def pretraining_test_helper(tokenizer, model, algorithms, tmp_path, device):
model=pretraining_model_copy,
train_dataloader=pretraining_train_dataloader,
save_folder=str(tmp_path / 'pretraining_checkpoints'),
max_duration='1ba',
max_duration='2ba',
seed=17,
algorithms=algorithms,
device=device,
Expand Down Expand Up @@ -138,7 +138,7 @@ def finetuning_test_helper(tokenizer, model, algorithms, checkpoint_path, pretra
load_weights_only=True,
load_strict_model_weights=False,
loggers=[rud],
max_duration='1ba',
max_duration='2ba',
seed=17,
algorithms=algorithms,
device=device,
Expand Down
Loading