-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor maybe_create_object_store_from_uri
#3679
Conversation
7b1b906
to
f7a6d56
Compare
maybe_create_object_store_from_uri
extensiblemaybe_create_object_store_from_uri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test for registering a mock option?
@mvpatel2000 The existing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. not sure why comments are removed though
01cbcf6
to
a501786
Compare
What does this PR do?
Refactors
maybe_create_object_store_from_uri
to use a dictionary, which maps backend strings to object store factory functions.What issue(s) does this change relate to?
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)