Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version tag to local builds with git #3193

Closed
wants to merge 5 commits into from
Closed

Add version tag to local builds with git #3193

wants to merge 5 commits into from

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Apr 15, 2024 •
edited
Loading

What does this PR do?

Add version tag to local builds

❯ python
Python 3.10.12 (main, Jun 20 2023, 19:43:52) [Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import composer
composer.__version>>> composer.__version__
'0.21.2+05e568b'
>>> quit()

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner April 15, 2024 17:36
j316chuck
j316chuck reviewed Apr 15, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 changed the title Add version tag to local builds Add version tag to local builds with git Apr 15, 2024
j316chuck
j316chuck approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this QOL improvement!

@mvpatel2000
Copy link
Contributor Author

Closing, this one seems to be much brittle

@mvpatel2000 mvpatel2000 deleted the mvpatel2000/add-dev-tag-2 branch April 15, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j316chuck j316chuck j316chuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @j316chuck