Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Certora] Verify mint and burn #93

Merged
merged 16 commits into from
Dec 11, 2024
Merged

[Certora] Verify mint and burn #93

merged 16 commits into from
Dec 11, 2024

Conversation

colin-morpho
Copy link
Contributor

@colin-morpho colin-morpho commented Nov 8, 2024

The verification ensures that the Morpho token mint and burn function is compliant with the ERC20 specification.
It patches the OZ specification for ERC20 to support the upgradeable version.

Replaces #85

TODO:

  • README is updated;
  • verification succeed;
  • CI is updated.

@colin-morpho colin-morpho changed the title Colin@verif/mint burn [Certora] Verify mint and burn Nov 8, 2024
This was referenced Nov 8, 2024
@colin-morpho colin-morpho self-assigned this Nov 8, 2024
@colin-morpho colin-morpho added the verif Formal Verification label Nov 8, 2024
@colin-morpho colin-morpho marked this pull request as ready for review November 8, 2024 20:40
@colin-morpho
Copy link
Contributor Author

Related discussion in #85 (comment)

@QGarchery
Copy link
Contributor

Can you point to the right branch @colin-morpho ? At the moment this is showing a lot of changes

@colin-morpho colin-morpho changed the base branch from main to colin@verif/erc20 November 12, 2024 13:26
@colin-morpho colin-morpho changed the base branch from colin@verif/erc20 to colin@verif/delegation November 12, 2024 13:26
@colin-morpho
Copy link
Contributor Author

@QGarchery my bad, just changed it.

certora/README.md Outdated Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnOptimism.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnOptimism.spec Outdated Show resolved Hide resolved
Base automatically changed from colin@verif/delegation to main December 4, 2024 16:59
@colin-morpho colin-morpho changed the base branch from main to colin@verif/delegation-invariants December 6, 2024 09:25
Base automatically changed from colin@verif/delegation-invariants to main December 6, 2024 15:37
certora/specs/ERC20Invariants.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change to make, and after #99

certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Outdated Show resolved Hide resolved
certora/specs/MintBurnOptimism.spec Outdated Show resolved Hide resolved
Signed-off-by: Colin | Morpho 🦋 <[email protected]>
QGarchery
QGarchery previously approved these changes Dec 10, 2024
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will conflict with #102, so it should probably be merged after

MathisGD
MathisGD previously approved these changes Dec 10, 2024
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only questions, good to merge!

certora/specs/MintBurnOptimism.spec Show resolved Hide resolved
certora/README.md Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
certora/specs/MintBurnEthereum.spec Show resolved Hide resolved
@colin-morpho colin-morpho merged commit d828ef0 into main Dec 11, 2024
16 checks passed
@colin-morpho colin-morpho deleted the colin@verif/mint-burn branch December 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verif Formal Verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants