[Certora] If calls succeed state changes #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-morpho
force-pushed
the
colin@verif/reverts-alt
branch
from
1648ac9 to
1a21f46
Compare
colin-morpho
commented
Jan 15, 2025
MathisGD
reviewed
Jan 15, 2025
QGarchery
reviewed
Jan 16, 2025
|
For reference, comments of interest made on #227. |
colin-morpho
changed the title
6 tasks
QGarchery
reviewed
Jan 17, 2025
MathisGD
reviewed
Jan 23, 2025
Co-authored-by: MathisGD <[email protected]> Signed-off-by: Colin | Morpho 🦋 <[email protected]>
QGarchery
approved these changes
Jan 29, 2025
| "Address": "solc-0.8.28", | ||
| "Permit2Lib": "solc-0.8.28", | ||
| "AllowanceTransfer": "solc-0.8.17", | ||
| "WETH9": "solc-0.5.15" |
There was a problem hiding this comment.
Isn't it compiled with version 0.4.19 ? See here
| "lib/morpho-blue/src/Morpho.sol", | ||
| "lib/openzeppelin-contracts/contracts/token/ERC20/utils/SafeERC20.sol", | ||
| "lib/permit2/src/libraries/Permit2Lib.sol", | ||
| "lib/permit2/src/AllowanceTransfer.sol", |
There was a problem hiding this comment.
We could use the Permit2 contract directly (which inherits from AllowanceTransfer). I know it's not necessary, but AllowanceTransfer is not really well-known compared to Permit2
Comment on lines
+65
to
+66
| assert (receiver == Bundler3.initiator() && token.allowance(e, Bundler3.initiator(), currentContract) == max_uint256 => storageBefore == lastStorage) && | ||
| (storageBefore == lastStorage => receiver == Bundler3.initiator() && token.allowance(e, Bundler3.initiator(), currentContract) == max_uint256); |
There was a problem hiding this comment.
(optional) could apply to other places where equivalence is rewritten as well
Suggested change
| assert (receiver == Bundler3.initiator() && token.allowance(e, Bundler3.initiator(), currentContract) == max_uint256 => storageBefore == lastStorage) && | |
| (storageBefore == lastStorage => receiver == Bundler3.initiator() && token.allowance(e, Bundler3.initiator(), currentContract) == max_uint256); | |
| bool noChangeExpectedCondition = receiver == Bundler3.initiator() && token.allowance(e, Bundler3.initiator(), currentContract) == max_uint256 ; | |
| assert (noChangeExpectedCondition => storageBefore == lastStorage) && | |
| (storageBefore == lastStorage => noChangeExpectedCondition); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #227.
We verify, up to some exceptions, that whenever an adapter function is called the states changes or the execution reverts.
We try to this in most general fashion, using a parametric rule.
Before accepting this PR please check that: