Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mass delete subtitle files #2816

Conversation

phyzical
Copy link
Contributor

@phyzical phyzical commented Jan 8, 2025

supports mass deletion for both movies and episodes

movies.mov
episodes.mov

@phyzical
Copy link
Contributor Author

phyzical commented Jan 8, 2025

one issue ive noticed is that the mass delete doesn't seem to async all requests to the backend.
So if you navigate away/refresh it stops and acts like its mid form submission?

i assume the backend aborts is there anyway to enforce all queued tasks keep running?

edit: ah i see thats what task create is designed to do, is there another version designed to queue an async list or persist?

@anderson-oki anderson-oki self-requested a review January 8, 2025 06:12
@anderson-oki
Copy link
Collaborator

one issue ive noticed is that the mass delete doesn't seem to async all requests to the backend. So if you navigate away/refresh it stops and acts like its mid form submission?

i assume the backend aborts is there anyway to enforce all queued tasks keep running?

edit: ah i see thats what task create is designed to do, is there another version designed to queue an async list or persist?

No, currently there is nothing that keeps alive in the frontend, the ideal implementation would need to proper implement on the backend a bulk action and add to the queue, so a single request goes from the frontend but that will require much more effort.

bazarr/README.md Outdated Show resolved Hide resolved
@morpheus65535
Copy link
Owner

one issue ive noticed is that the mass delete doesn't seem to async all requests to the backend. So if you navigate away/refresh it stops and acts like its mid form submission?
i assume the backend aborts is there anyway to enforce all queued tasks keep running?
edit: ah i see thats what task create is designed to do, is there another version designed to queue an async list or persist?

No, currently there is nothing that keeps alive in the frontend, the ideal implementation would need to proper implement on the backend a bulk action and add to the queue, so a single request goes from the frontend but that will require much more effort.

It's been on our backlog for a while. Maybe one day ;-)

@phyzical phyzical requested a review from anderson-oki January 9, 2025 05:50
@phyzical
Copy link
Contributor Author

phyzical commented Jan 9, 2025

Updated the name, removed the readme and closed the modal when actioning

If you know how we can easily fix the scroll so that the action button is basically a footer LMK i couldn't see how to easily pull it off with this css lib

@anderson-oki anderson-oki changed the title Feature/463444 mass delete subtitle files Added mass delete subtitle files Jan 10, 2025
@anderson-oki anderson-oki merged commit f146d97 into morpheus65535:development Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants