Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created a release action #5

Merged
merged 2 commits into from
Nov 23, 2023
Merged

created a release action #5

merged 2 commits into from
Nov 23, 2023

Conversation

aidanm3341
Copy link
Member

Upon merge, this would release version 1.0.0 of the message-broker to npm

@aidanm3341 aidanm3341 self-assigned this Nov 23, 2023
bingenito
bingenito reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@bingenito bingenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On push is continuous delivery? Do you want a release on every merge? That will be a bit much once dependabot kicks in

@aidanm3341
Copy link
Member Author

good point @bingenito, I have changed it to trigger when we create a new GitHub release for now. I think having it manual like this is good for now

@aidanm3341 aidanm3341 merged commit a8cf341 into main Nov 23, 2023
4 checks passed
@aidanm3341 aidanm3341 deleted the release-action branch November 23, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingenito bingenito bingenito approved these changes

@mimiflynn mimiflynn Awaiting requested review from mimiflynn

@Davidhanson90 Davidhanson90 Awaiting requested review from Davidhanson90

@Roaders Roaders Awaiting requested review from Roaders

Assignees

@aidanm3341 aidanm3341

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidanm3341 @bingenito