Merge pull request #121 from moovfinancial/update-account-types

Update with new bank account types
moovfinancial · Sep 13, 2024 · d6da95e · d6da95e
2 parents 1f1ca4e + c5f32ec
commit d6da95e
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/docs/output/bank-accounts.md b/docs/output/bank-accounts.md
@@ -261,6 +261,7 @@ Describes a Bank Account to be added.
 | ----- | ----------- |
 | CHECKING | Bank Account is a type of checking. |
 | SAVINGS | Bank Account is a type of savings. |
-| UNKNOWN | Bank Account is a type of unknown. |
+| LOAN | Bank Account is a type of loan. |
+| GENERAL_LEDGER | Bank Account is a type of general ledger. |
 {{</ table >}}
 
diff --git a/docs/output/transfers.md b/docs/output/transfers.md
@@ -390,7 +390,7 @@ High-level account information associated with a payment method.
   | holderName | `string`| Name of the account holder |
   | holderType | `individual`,  `business`| Type of holder on a funding source |
   | bankName | `string`| Name of the bank |
-  | bankAccountType | `checking`,  `savings`,  `unknown`|  |
+  | bankAccountType | `checking`,  `savings`,  `loan`,  `general-ledger`| The bank account type |
   | routingNumber | `string`| Bank account routing number |
   | lastFourAccountNumber | `string`| Last four digits of the bank account number |
 

diff --git a/lib/bankAccountsTypedefs.js b/lib/bankAccountsTypedefs.js
@@ -63,11 +63,17 @@
      */
     SAVINGS: "savings",
     /**
-     * Bank Account is a type of unknown.
+     * Bank Account is a type of loan.
      * @tag Bank accounts
      */
-    UNKNOWN: "unknown"
+    LOAN: "loan",
+    /**
+     * Bank Account is a type of general ledger.
+     * @tag Bank accounts
+     */
+    GENERAL_LEDGER: "general-ledger"
    }
+
 
 /**
  * Describes a Bank Account.

diff --git a/lib/transfers.js b/lib/transfers.js
@@ -28,7 +28,7 @@ import { Address } from "./address.js";
  * @property {string} holderName - Name of the account holder
  * @property {"individual"|"business"} holderType - Type of holder on a funding source
  * @property {string} bankName - Name of the bank
- * @property {"checking"|"savings"|"unknown"} bankAccountType
+ * @property {"checking"|"savings"|"loan"|"general-ledger"} bankAccountType - The bank account type
  * @property {string} routingNumber - Bank account routing number
  * @property {string} lastFourAccountNumber - Last four digits of the bank account number
  * @tag Transfers

diff --git a/lib/types/bankAccountsTypedefs.d.ts b/lib/types/bankAccountsTypedefs.d.ts
@@ -15,7 +15,8 @@ export type BANK_ACCOUNT_TYPE = any;
 export namespace BANK_ACCOUNT_TYPE {
     const CHECKING: string;
     const SAVINGS: string;
-    const UNKNOWN: string;
+    const LOAN: string;
+    const GENERAL_LEDGER: string;
 }
 /**
  * Describes a Bank Account.

diff --git a/lib/types/transfers.d.ts b/lib/types/transfers.d.ts
@@ -21,7 +21,7 @@
  * @property {string} holderName
  * @property {"individual"|"business"} holderType
  * @property {string} bankName
- * @property {"checking"|"savings"|"unknown"} bankAccountType
+ * @property {"checking"|"savings"|"loan"|"general-ledger"} bankAccountType
  * @property {string} routingNumber
  * @property {string} lastFourAccountNumber
  * @tag Transfers
@@ -416,7 +416,7 @@ export type BankAccount = {
     holderName: string;
     holderType: "individual" | "business";
     bankName: string;
-    bankAccountType: "checking" | "savings" | "unknown";
+    bankAccountType: "checking" | "savings" | "loan" | "general-ledger";
     routingNumber: string;
     lastFourAccountNumber: string;
 };