Weights per runtime #3019
Open
Weights per runtime #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-runtime # Conflicts: # runtime/common/src/lib.rs # runtime/moonbase/src/weights/pallet_xcm_weight_trader.rs # runtime/moonbeam/src/lib.rs # runtime/moonbeam/src/precompiles.rs # runtime/moonriver/src/precompiles.rs
gonzamontiel
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2256 KB (no changes) ✅ Moonbeam runtime: 2232 KB (no changes) ✅ Moonriver runtime: 2228 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2256 KB (+228 KB compared to latest release) Moonbeam runtime: 2232 KB (+236 KB compared to latest release) Moonriver runtime: 2228 KB (+236 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master gonza/weights-per-runtime +/- ##
=============================================================
- Coverage 79.00% 74.55% -4.45%
+ Files 305 375 +70
+ Lines 88470 94731 +6261
=============================================================
+ Hits 69890 70626 +736
+ Misses 18580 24105 +5525
|
…ation/moonbeam into gonza/weights-per-runtime
RomarQ
reviewed
Nov 11, 2024
|
We also need to update strategy:
matrix:
runtime: [moonbeam, moonbase, moonriver] |
RomarQ
reviewed
Nov 15, 2024
| // Standard Error: 22_805 | ||
| .saturating_add(Weight::from_parts(293_496_971, 0).saturating_mul(n.into())) | ||
| // Minimum execution time: 2_128_000 picoseconds. | ||
| Weight::from_parts(91_853_295, 3517) |
There was a problem hiding this comment.
It's weird, I don't see a big difference in the final weights comparison: 393.97ms to 393.71ms using subweight.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR replaces #2939.
It modifies pallet's benchmarks and removes magic numbers to be runtime-dependant.
What important points reviewers should know?
Pallet parachain staking had some fixed numbers that I replaced by values we get from the runtime. This might go against the testing purpose, because now a change on those parameters might go unnoticed in the test. Anyway I think it is an acceptable trade off.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?