Skip to content

Commit

Permalink
WP-5102 add 4.5 to supported versions, remove testing on PHP7.3
Browse files Browse the repository at this point in the history
  • Loading branch information
marinaglancy committed Oct 7, 2024
1 parent 3365bd4 commit dd96a92
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
11 changes: 2 additions & 9 deletions .github/workflows/moodle-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ jobs:
fail-fast: false
matrix:
include:
- php: '7.3'
moodle-branch: 'MOODLE_400_STABLE'
database: pgsql
extensions:
civersion: 3
- php: '8.0'
moodle-branch: 'MOODLE_400_STABLE'
database: mariadb
Expand Down Expand Up @@ -77,8 +72,7 @@ jobs:

- name: Initialise moodle-plugin-ci
run: |
civersion=$(if [[ "${{ matrix.civersion }}" == "3" ]]; then echo "^3"; else echo "^4"; fi)
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci $civersion
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4
echo $(cd ci/bin; pwd) >> $GITHUB_PATH
echo $(cd ci/vendor/bin; pwd) >> $GITHUB_PATH
sudo locale-gen en_AU.UTF-8
Expand Down Expand Up @@ -110,8 +104,7 @@ jobs:

- name: Moodle PHPDoc Checker
if: ${{ always() }}
# Skip for ci^3 since it may give different results on the old version and --max-warnings is not supported
run: if [[ "${{ matrix.civersion }}" == "3" ]]; then true; else moodle-plugin-ci phpdoc --max-warnings 0; fi
run: moodle-plugin-ci phpdoc --max-warnings 0

- name: Validating
if: ${{ always() }}
Expand Down
2 changes: 1 addition & 1 deletion version.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@
$plugin->version = 2024090300;
$plugin->requires = 2022041900.00;
$plugin->maturity = MATURITY_STABLE;
$plugin->supported = [400, 404];
$plugin->supported = [400, 405];

0 comments on commit dd96a92

Please sign in to comment.