Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate Plugin contribution main page #694

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

vmdef
Copy link
Contributor

@vmdef vmdef commented Jul 27, 2023

There is an open issue in Tracker for this migration where the location of the documentation was noted MDLSITE-7295

I created a folder to include all pages related to the plugin's contribution process. This patch is just for the main page.

I have updated the links and retained the original content to ensure that all the relevant documentation is migrated before making any changes.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b743274
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/64cbbf43a8315900089f9925
😎 Deploy Preview https://deploy-preview-694--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vmdef vmdef force-pushed the plugin_contribution branch 4 times, most recently from 9251419 to db85bc1 Compare July 27, 2023 19:47
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 56 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🔴 38 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🔴 46 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🔴 41 🟠 87 🟢 92 🟢 100 🟢 100 Report

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola Víctor!
Thanks a lot for migrating this page! It looks great and, as you'll see, I have only a few suggestions (that you can ignore if you don't like them).

general/community/plugincontribution/index.md Outdated Show resolved Hide resolved
general/community/plugincontribution/index.md Outdated Show resolved Hide resolved
general/community/plugincontribution/index.md Outdated Show resolved Hide resolved
general/community/plugincontribution/index.md Show resolved Hide resolved
general/community/plugincontribution/index.md Outdated Show resolved Hide resolved
Created a folder to include all pages related to the
plugins contribution process. This patch is just for the
main page.
Co-authored-by: Sara Arjona <[email protected]>

Format improvement: highlight text

Co-authored-by: Sara Arjona <[email protected]>

Fix links

Co-authored-by: Sara Arjona <[email protected]>

Fix database links

Co-authored-by: Sara Arjona <[email protected]>

Format improvement: add info block

Co-authored-by: Sara Arjona <[email protected]>
@vmdef
Copy link
Contributor Author

vmdef commented Aug 3, 2023

Hi, @sarjona.

Thank you for your review and for providing excellent suggestions. I have implemented all of them in a new commit.

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing the PR and including the suggestions <3
The page looks great so I'm happy to merge it! Well done!

@sarjona sarjona added this pull request to the merge queue Aug 4, 2023
Merged via the queue into moodle:main with commit 3c696a3 Aug 4, 2023
7 checks passed
@vmdef vmdef deleted the plugin_contribution branch August 11, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants