Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MOODLE_405_STABLE to Bash script #1148

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add MOODLE_405_STABLE to Bash script #1148

merged 1 commit into from
Oct 7, 2024

Conversation

leonstr
Copy link
Contributor

@leonstr leonstr commented Oct 7, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8a92f8f
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6703f95a7d57320008929cfd
😎 Deploy Preview https://deploy-preview-1148--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 61 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🔴 43 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 67 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 65 🟢 95 🟢 100 🟢 100 🟢 100 Report

andrewnicols
andrewnicols requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leonstr,

This change belongs in docs/guides/git/index.md, not in the 4.4 variant

@leonstr
Copy link
Contributor Author

leonstr commented Oct 7, 2024

Thank you for the feedback. I've attempted to do this to the best of my understanding.

@andrewnicols
Copy link
Member

Thanks @leonstr ,

Looks good to me. Merging.

@andrewnicols andrewnicols added this pull request to the merge queue Oct 7, 2024
Merged via the queue into moodle:main with commit 310a76c Oct 7, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnicols andrewnicols andrewnicols approved these changes

Assignees

@leonstr leonstr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonstr @andrewnicols