Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Explain changes done in reset course page - Blocked by MDL-81872 #1032

Merged
merged 2 commits into from
May 28, 2024

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented May 27, 2024

This should be integrated when https://tracker.moodle.org/browse/MDL-81872 is merged.

@sarjona sarjona added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label May 27, 2024
Copy link

netlify bot commented May 27, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 26f65ad
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6655336c9b19f200088b0ffc
😎 Deploy Preview https://deploy-preview-1032--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented May 27, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 78 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 71 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 78 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 65 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments seem OK and explain changes made in MDL-81872

@andrewnicols andrewnicols added this pull request to the merge queue May 28, 2024
Merged via the queue into moodle:main with commit ecd12b9 May 28, 2024
6 of 7 checks passed
@andrewnicols
Copy link
Member

Note: I added an extra commit to:

  • tweak wording; and
  • fix indentation of the code block

The indentation was necessary to fix the markup and keep the codeblock as a part of the parent LI. Without it being indented it is treated as a separate entity leading to markup resembling:

UL
  LI

CODE

UL
  LI

By indenting the backticks it becomes:

UL
  LI
    CODE
  LI

@sarjona
Copy link
Member Author

sarjona commented May 28, 2024

Thanks a lot for improving the patch and sharing this useful information Andrew! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants