Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Document \core\clock in more places #1022

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[docs] Document \core\clock in more places #1022

merged 1 commit into from
Jun 10, 2024

Conversation

andrewnicols
Copy link
Member

Relates to MDL-81894

@andrewnicols andrewnicols added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label May 17, 2024
@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 740a36c
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/66665e782fa30e00088fce0d
😎 Deploy Preview https://deploy-preview-1022--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 71 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 72 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 75 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 82 🟢 95 🟢 100 🟢 100 🟢 100 Report

@andrewnicols
Copy link
Member Author

@junpataleta

junpataleta
junpataleta approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andrewnicols . This looks pretty much spot-on. Just a minor trailing backtick at the end of the "Why use the Clock?" section. Feel free to address and merge when ready.

Cheers!

docs/apis/subsystems/time/index.md Outdated Show resolved Hide resolved
@andrewnicols andrewnicols added this pull request to the merge queue Jun 10, 2024
Merged via the queue into moodle:main with commit e554e89 Jun 10, 2024
7 checks passed
@andrewnicols andrewnicols deleted the MDL-81894 branch June 10, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpataleta junpataleta junpataleta approved these changes

Assignees

@andrewnicols andrewnicols

Labels
blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnicols @junpataleta