-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert svg icons to components #7394
Conversation
|
@ibrahimBougaoua that's awesome! Thank you |
Ok I'll finish the rest |
Hi |
This is indeed, really great. I didn't do it in the first place because I didn't want to put too much stress on the shadow DOM with too many components, but at the end of the day, it doesn't really matter. Vue is made for that. |
I couldn't commit to this branch so I "forked" it and pushed it here: #7426 Thanks so much for your hard work!! |
Thanks. |
Hi,
I converted some svg icons code to components,
If this is ok, I will complete the rest of the icons.
Thanks.