Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert svg icons to components #7394

Closed
wants to merge 6 commits into from

Conversation

ibrahimBougaoua
Copy link
Contributor

Hi,
I converted some svg icons code to components,
If this is ok, I will complete the rest of the icons.
Thanks.

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ asbiin
✅ djaiss
❌ ibrahimBougaoua
You have signed the CLA already but the status is still pending? Let us recheck it.

@ibrahimBougaoua ibrahimBougaoua changed the title Convert some svg icons code to components [ Enhancement ] Convert some svg icons code to components Oct 5, 2024
@asbiin
Copy link
Member

asbiin commented Oct 6, 2024

@ibrahimBougaoua that's awesome! Thank you

@ibrahimBougaoua
Copy link
Contributor Author

@ibrahimBougaoua that's awesome! Thank you

Ok I'll finish the rest

@ibrahimBougaoua
Copy link
Contributor Author

Hi
i finished the rest of icons that placed inside folder [ shared ]
check it please.

@asbiin

@djaiss
Copy link
Member

djaiss commented Oct 27, 2024

This is indeed, really great.

I didn't do it in the first place because I didn't want to put too much stress on the shadow DOM with too many components, but at the end of the day, it doesn't really matter. Vue is made for that.

@djaiss djaiss changed the title [ Enhancement ] Convert some svg icons code to components refactor: convert svg icons to components Oct 27, 2024
@djaiss
Copy link
Member

djaiss commented Oct 27, 2024

I couldn't commit to this branch so I "forked" it and pushed it here: #7426

Thanks so much for your hard work!!

@djaiss djaiss closed this Oct 27, 2024
@ibrahimBougaoua
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants