Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a name order with the last name outside of brackets #6286

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

andrewaylett
Copy link

This fixes #6285.

Where nicknames are used as diminutives of full first names, it (hopefuly) makes sense to indicate as such in both the full name and short name fields.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022

CLA assistant check
All committers have signed the CLA.

@andrewaylett andrewaylett marked this pull request as draft August 26, 2022 18:51
@andrewaylett andrewaylett marked this pull request as ready for review August 27, 2022 21:21
@flyinprogrammer
Copy link

flyinprogrammer commented Sep 18, 2023

It would be great to have this feature ported to chandler, it was the first thing my significant other asked about 😂

Looks like this is sort covered already: https://docs.monicahq.com/user-and-account-settings/manage-preferences#customize-contact-names

though it would be nice if the template allowed for some logic, like optionally showing a nickname in brackets but only if it exists.

@asbiin asbiin added the reviewed label Nov 5, 2023
@asbiin asbiin merged commit 0a9112e into monicahq:4.x Nov 5, 2023
18 checks passed
Copy link

github-actions bot commented Nov 5, 2024

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nickname with bracketed first name
4 participants