Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5091: make drawers ToC nodes link to page #1341

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Jan 24, 2025

Stories/Links:

DOP-5091
This PR makes drawer ToC's accessible as links to enable offline users to navigate the pages directly without having to use the caret markers. These pages are not marked in the contents' toc_landing_pages (example here) so they do not have a link in the live site.

Current Behavior:

Currently, this example page is accessible in prod but not through the ToC.
Regression check with the env flag off

Staging Links:

Sample S3 file is here. Note that you can navigate to the Reference ToC. This will be post processed by the netlify extension that updates the link path to be a relative filename.

Notes:

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit f185cf6
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/679408814f1eca0008e2cb12
😎 Deploy Preview https://deploy-preview-1341--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit f185cf6
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/67940881dc33b600080b3ccf
😎 Deploy Preview https://deploy-preview-1341--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seungpark seungpark marked this pull request as ready for review January 24, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant