-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(NODE-6616): shortcircuit logging ejson.stringify #4377
Conversation
…nt constructors (#4371)
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be some quick fixes, looks good
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Req Changes for viz
I think we just need to correct the Uint8Array case
Description
What is changing?
Add logic to short-circuit the EJSON.stringify call when logging.
Note that the logic here only accounts for types that are cheap to check the length of, so we notably don't account for the following BSON types
Is there new documentation needed for these changes?
What is the motivation for this change?
Improve performance of Command logging
Release Highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript