Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-3278 Port OIDC machine callback to master #1712

Merged
merged 23 commits into from
Aug 1, 2024

Conversation

blink1073
Copy link
Member

GODRIVER-3278

Summary

Port OIDC functionality to master.

@blink1073 blink1073 changed the title GODRIVER-3278 GODRIVER-3278 Port OIDC to master Jul 24, 2024
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Jul 24, 2024
Copy link
Contributor

mongodb-drivers-pr-bot bot commented Jul 24, 2024

API Change Report

./mongo/options

compatible changes

Credential.OIDCHumanCallback: added
Credential.OIDCMachineCallback: added
IDPInfo: added
OIDCArgs: added
OIDCCallback: added
OIDCCredential: added

./x/mongo/driver

compatible changes

AuthConfig: added
Authenticator: added
Cred: added
IDPInfo: added
OIDCArgs: added
OIDCCallback: added
OIDCCredential: added
Operation.Authenticator: added

./x/mongo/driver/auth

incompatible changes

##(*DefaultAuthenticator).Auth: changed from func(context.Context, *Config) error to func(context.Context, *./x/mongo/driver.AuthConfig) error
##(*MongoDBAWSAuthenticator).Auth: changed from func(context.Context, *Config) error to func(context.Context, *./x/mongo/driver.AuthConfig) error
##(*MongoDBCRAuthenticator).Auth: changed from func(context.Context, *Config) error to func(context.Context, *./x/mongo/driver.AuthConfig) error
##(*MongoDBX509Authenticator).Auth: changed from func(context.Context, *Config) error to func(context.Context, *./x/mongo/driver.AuthConfig) error
##(*PlainAuthenticator).Auth: changed from func(context.Context, *Config) error to func(context.Context, *./x/mongo/driver.AuthConfig) error
##(*ScramAuthenticator).Auth: changed from func(context.Context, *Config) error to func(context.Context, *./x/mongo/driver.AuthConfig) error
##Authenticator: changed from Authenticator to ./x/mongo/driver.Authenticator
##AuthenticatorFactory: changed from func(Cred) (Authenticator, error) to func(./x/mongo/driver.Cred, *net/http.Client) (./x/mongo/driver.Authenticator, error)
##ConductSaslConversation: changed from func(context.Context, *Config, string, SaslClient) error to func(context.Context, *./x/mongo/driver.AuthConfig, string, SaslClient) error
##CreateAuthenticator: changed from func(string, *Cred) (Authenticator, error) to func(string, *./x/mongo/driver.Cred, *net/http.Client) (./x/mongo/driver.Authenticator, error)
##Cred: changed from Cred to ./x/mongo/driver.Cred
##DefaultAuthenticator.Cred: changed from *Cred to *./x/mongo/driver.Cred
##HandshakeOptions.Authenticator: changed from Authenticator to ./x/mongo/driver.Authenticator
HandshakeOptions.HTTPClient: removed
##SpeculativeConversation.Finish: changed from func(context.Context, *Config, ./x/bsonx/bsoncore.Document) error to func(context.Context, *./x/mongo/driver.AuthConfig, ./x/bsonx/bsoncore.Document) error

compatible changes

(*DefaultAuthenticator).Reauth: added
(*MongoDBAWSAuthenticator).Reauth: added
(*MongoDBCRAuthenticator).Reauth: added
(*MongoDBX509Authenticator).Reauth: added
(*PlainAuthenticator).Reauth: added
(*ScramAuthenticator).Reauth: added
IDPInfo: added
MongoDBOIDC: added
OIDCArgs: added
OIDCAuthenticator: added
OIDCCallback: added
OIDCCredential: added

./x/mongo/driver/drivertest

compatible changes

(*ChannelConn).OIDCTokenGenID: added
(*ChannelConn).SetOIDCTokenGenID: added

./x/mongo/driver/mnet

incompatible changes

Describer.OIDCTokenGenID: added
Describer.SetOIDCTokenGenID: added
NewConnection: changed from func(interface{ReadWriteCloser; Describer}) *Connection to func(interface{ReadWriteCloser; Describer}) *Connection

compatible changes

Describer.OIDCTokenGenID: added
Describer.SetOIDCTokenGenID: added

./x/mongo/driver/operation

compatible changes

(*AbortTransaction).Authenticator: added
(*Aggregate).Authenticator: added
(*Command).Authenticator: added
(*CommitTransaction).Authenticator: added
(*Count).Authenticator: added
(*Create).Authenticator: added
(*CreateIndexes).Authenticator: added
(*CreateSearchIndexes).Authenticator: added
(*Delete).Authenticator: added
(*Distinct).Authenticator: added
(*DropCollection).Authenticator: added
(*DropDatabase).Authenticator: added
(*DropIndexes).Authenticator: added
(*DropSearchIndex).Authenticator: added
(*EndSessions).Authenticator: added
(*Find).Authenticator: added
(*FindAndModify).Authenticator: added
(*Hello).Authenticator: added
(*Insert).Authenticator: added
(*ListCollections).Authenticator: added
(*ListDatabases).Authenticator: added
(*ListIndexes).Authenticator: added
(*Update).Authenticator: added
(*UpdateSearchIndex).Authenticator: added

./x/mongo/driver/session

incompatible changes

##./x/mongo/driver/mnet.Describer.OIDCTokenGenID: added
##./x/mongo/driver/mnet.Describer.SetOIDCTokenGenID: added

./x/mongo/driver/topology

compatible changes

(*Connection).OIDCTokenGenID: added
(*Connection).SetOIDCTokenGenID: added
NewConfigFromOptionsWithAuthenticator: added

@blink1073 blink1073 marked this pull request as ready for review July 24, 2024 19:42
mongo/collection.go Outdated Show resolved Hide resolved
matthewdale
matthewdale previously approved these changes Jul 31, 2024
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@blink1073
Copy link
Member Author

I had to address a few import and lint failures since your review.

@blink1073 blink1073 changed the title GODRIVER-3278 Port OIDC to master GODRIVER-3278 Port OIDC machine callback to master Aug 1, 2024
@blink1073 blink1073 merged commit 5876554 into mongodb:master Aug 1, 2024
30 of 34 checks passed
@blink1073 blink1073 deleted the GODRIVER-3278 branch August 1, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants