GODRIVER-3245 [master] Use a custom CodeQL workflow. #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6e75330)
API Change ReportNo changes found! |
qingyang-hu
reviewed
Jun 14, 2024
Comment on lines
+19
to
+20
| runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} | ||
| timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }} |
There was a problem hiding this comment.
Do we need the condition for "swift"?
There was a problem hiding this comment.
We're going to follow up with some cleanup, this is just to get something in place. 😄
qingyang-hu
approved these changes
Jun 14, 2024
blink1073
deleted the
cherry-pick-6e75330aac2039a82e635fa30d76e1465f9d8644
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1674 from v1 to master