GODRIVER-3107 Fix leaking rttMonitor.runHellos() routine. #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
qingyang-hu
commented
Mar 29, 2024
| s.pool.close(ctx) | ||
|
|
||
| s.closewg.Wait() | ||
| s.rttMonitor.disconnect() |
There was a problem hiding this comment.
It does not cause any actual impact whether or not this line is moved. I put it here as a "fail-safe" that disconnects after the update() exits, so rttMonitor.connect() is more likely to be called beforehand.
qingyang-hu
added
priority-2-medium
matthewdale
requested changes
Apr 17, 2024
x/mongo/driver/topology/server.go
Outdated
| @@ -125,6 +125,7 @@ type Server struct { | |||
|
|
|||
| processErrorLock sync.Mutex | |||
| rttMonitor *rttMonitor | |||
| monitorOnce *sync.Once | |||
There was a problem hiding this comment.
Since Server is always passed as a pointer, this sync.Once can be a non-pointer type (like sync.Mutex above). If it is ever copied, the go vet linter will cause an error.
prestonvasquez
approved these changes
Apr 22, 2024
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Apr 22, 2024
(cherry picked from commit 9648fe1)
qingyang-hu
added a commit
that referenced
this pull request
May 8, 2024
qingyang-hu
added a commit
that referenced
this pull request
May 8, 2024
matthewdale
pushed a commit
to matthewdale/mongo-go-driver
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3107
Summary
Fix the leaky
rttMonitor.runHellos()routine when a disconnect occurs before a connection takes place.Background & Motivation
There is a chance that
rttMonitor.disconnect()is called beforerttMonitor.connect()as described in PR #1376. In that case, the condition indisconnect()triggers a shortcut return which makes therunHellos()routine impossible to be closed.